Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved the default datalink viewer #143

Merged
merged 2 commits into from
Jan 26, 2023
Merged

improved the default datalink viewer #143

merged 2 commits into from
Jan 26, 2023

Conversation

agy-why
Copy link
Member

@agy-why agy-why commented Jan 25, 2023

improve the datalink viewer:

  • less technical (hide non-necessary datalink columns)
  • human readable file size

@agy-why agy-why linked an issue Jan 25, 2023 that may be closed by this pull request
FEATURE: Improve the datalink default viewer #131
Closed
@agy-why agy-why requested a review from kimakan January 25, 2023 10:49
@agy-why agy-why self-assigned this Jan 25, 2023
@agy-why agy-why added this to the version 0.4.1 milestone Jan 25, 2023
@coveralls
Copy link

coveralls commented Jan 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4008144258

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.201%
Totals Coverage Status
Change from base Build 3995188500: 0.0%
Covered Lines: 4652
Relevant Lines: 7246
💛 - Coveralls

kimakan
kimakan approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@kimakan kimakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I cleaned up a few tabs and whitespaces in the code.

@agy-why agy-why merged commit a72d5da into master Jan 26, 2023
@agy-why agy-why deleted the 131-feature-improve-the-datalink-default-viewer branch January 26, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimakan kimakan kimakan approved these changes

Assignees

@agy-why agy-why

Labels
app:datalink concern the datalink-app category:datalink category:interface:WEB category:web-GUI enhancement priority:low
Projects
None yet
Milestone
version 0.4.1
Development

Successfully merging this pull request may close these issues.

FEATURE: Improve the datalink default viewer
3 participants
@agy-why @coveralls @kimakan