Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download of votables for ucd fields holding a None value #149

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Fix download of votables for ucd fields holding a None value #149

merged 1 commit into from
Feb 13, 2023

Conversation

kimakan
Copy link
Contributor

@kimakan kimakan commented Feb 10, 2023

See #148

@kimakan kimakan requested a review from agy-why February 10, 2023 13:43
@kimakan kimakan linked an issue Feb 10, 2023 that may be closed by this pull request
BUG: Error downloading table without ucd information #148
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4144451062

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.377%
Totals Coverage Status
Change from base Build 4104281142: 0.0%
Covered Lines: 4686
Relevant Lines: 7279
💛 - Coveralls

agy-why
agy-why approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@agy-why agy-why left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fine

@agy-why agy-why merged commit 5cf74bb into master Feb 13, 2023
@agy-why agy-why mentioned this pull request Feb 13, 2023
Closed
@agy-why agy-why deleted the 148-fix-downloading-table-without-ucd branch February 13, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agy-why agy-why agy-why approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Error downloading table without ucd information
3 participants
@kimakan @coveralls @agy-why