Merge in upstream #773
Closed
Merge in upstream #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we undefine the entire window.define, modules loaded asynchronously can randomly fail to register themselves. However, jQuery 2+ checks for define.amd before registering itself as an AMD module, not just define. So, by unsetting window.define.amd instead of window.define, we don't break define() for other modules and we still prevent the page-global jQuery from registering itself as an AMD module, which was the ultimate goal of jazzband#591.
Confirming merge.
Better name for the define.amd backup
|
oops, sorry - didn't me to open this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.