Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #296] Adding SearchAsYouType Field #303

Merged
merged 1 commit into from Feb 15, 2021

Conversation

safwanrahman
Copy link
Collaborator

@safwanrahman safwanrahman commented Oct 31, 2020

This fixes #296. It should be a small changes. As the field is added at es-dsl version 7.2.0, we should require that version in setup.py
@alexgarel r?

@barseghyanartur
Copy link
Contributor

Thumbs up for the SearchAsYouType addition. This, however, brings us to the branching hell. I still think that one codebase with tiny shims won't hurt at all. Since we can have ES version checks at no cost at all, we could define dummy classes and raise exceptions in case of version/feature conflicts.

@safwanrahman safwanrahman merged commit 417c183 into django-es:master Feb 15, 2021
@safwanrahman
Copy link
Collaborator Author

@barseghyanartur I can understand that! But this is how the upstream package is maintaining their version and I think its easier for us to align with them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchAsYouType Field
2 participants