Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 4.0 support #387

Merged
merged 1 commit into from Dec 8, 2021

Conversation

bence-the-great
Copy link
Contributor

  • force_text was removed in favor of force_str
  • ugettext_lazy was removed in favor of gettext_lazy
  • added Python 3.9 and 3.10 to the test matrix, because they're supported by Django 4.0 (while excluding Django versions, which do not support 3.9 and 3.10)

* force_text was removed in favor of force_str

* ugettext_lazy was removed in favor of gettext_lazy

* added Python 3.9 and 3.10 to the test matrix, because they're supported by Django 4.0 (while excluding Django versions, which do not support 3.9 and 3.10)
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #387 (1b4456b) into master (c0612d6) will decrease coverage by 9.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   67.67%   58.43%   -9.25%     
==========================================
  Files          12       12              
  Lines         758      883     +125     
==========================================
+ Hits          513      516       +3     
- Misses        245      367     +122     
Impacted Files Coverage Δ
django_elasticsearch_dsl/fields.py 55.50% <100.00%> (-5.96%) ⬇️
django_elasticsearch_dsl/documents.py 55.08% <0.00%> (-21.58%) ⬇️
django_elasticsearch_dsl/registries.py 57.79% <0.00%> (-16.38%) ⬇️
django_elasticsearch_dsl/__init__.py 90.90% <0.00%> (-9.10%) ⬇️
django_elasticsearch_dsl/test/testcases.py 96.29% <0.00%> (-3.71%) ⬇️
django_elasticsearch_dsl/apps.py 85.71% <0.00%> (-3.18%) ⬇️
...sticsearch_dsl/management/commands/search_index.py 39.03% <0.00%> (-3.16%) ⬇️
django_elasticsearch_dsl/signals.py 86.11% <0.00%> (-2.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0612d6...1b4456b. Read the comment docs.

Copy link
Collaborator

@safwanrahman safwanrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @bence92 🚀

@safwanrahman safwanrahman merged commit 39a8382 into django-es:master Dec 8, 2021
@bence-the-great bence-the-great deleted the django-upgrade-4-0 branch December 9, 2021 19:07
@sondrelg
Copy link

Do you intend on releasing a patch version with these changes soon @safwanrahman? I see it was merged a few days ago 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants