Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize index nested/object fields #412

Merged

Conversation

alexander3771
Copy link
Contributor

Hi!

We don't need to create brand new document for every field we index

@alexander3771
Copy link
Contributor Author

Hello, @safwanrahman!
Please take a look, this is small fix just to increase speed of index nested objects

Copy link
Collaborator

@safwanrahman safwanrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r+

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 49.81% // Head: 53.66% // Increases project coverage by +3.84% 🎉

Coverage data is based on head (89d2376) compared to base (6129dfc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   49.81%   53.66%   +3.84%     
==========================================
  Files          12       12              
  Lines        1088     1010      -78     
==========================================
  Hits          542      542              
+ Misses        546      468      -78     
Impacted Files Coverage Δ
django_elasticsearch_dsl/fields.py 57.20% <100.00%> (+7.61%) ⬆️
django_elasticsearch_dsl/documents.py 57.48% <0.00%> (+1.34%) ⬆️
...sticsearch_dsl/management/commands/search_index.py 27.92% <0.00%> (+1.80%) ⬆️
django_elasticsearch_dsl/registries.py 64.49% <0.00%> (+7.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@safwanrahman safwanrahman merged commit 0fb0805 into django-es:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants