Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Celery signal processor implement #414

Merged
merged 16 commits into from Oct 1, 2023
Merged

Celery signal processor implement #414

merged 16 commits into from Oct 1, 2023

Conversation

Bidaya0
Copy link
Contributor

@Bidaya0 Bidaya0 commented Jul 20, 2022 •
edited

base on #87

CorrosiveKid and others added 9 commits March 8, 2018 14:29
@CorrosiveKid
Implement the Celery signal processor
8ac007b 
The `CelerySignalProcessor` allows automatic updates on the index as delayed background tasks using Celery.

NB: We cannot process deletes as background tasks. By the time the Celery worker would pick up the delete job, the model instance would already deleted. We can get around this by setting Celery to use `pickle` and sending the object to the worker, but using `pickle` opens the application up to security concerns.
Draft implementation for different signal processor tests
5529c51
fix conflict
83a9a8c
@Bidaya0
requirements.txt update
68fe313
@Bidaya0
signal.py revert
fc9c643 
revert signals.py
@Bidaya0
update
13698a6
@Bidaya0
add delete task
0f069f8
@Bidaya0
add delete and delete_related perpare
33e82f6
@Bidaya0
fix import bug
75ca891
@Bidaya0 Bidaya0 changed the title Celery signal processor branch Celery signal processor implement base on https://github.com/django-es/django-elasticsearch-dsl/pull/87 Jul 20, 2022
@Bidaya0 Bidaya0 changed the title Celery signal processor implement base on https://github.com/django-es/django-elasticsearch-dsl/pull/87 Celery signal processor implement Jul 20, 2022
@Bidaya0 Bidaya0 mentioned this pull request Jul 21, 2022
Closed
@safwanrahman
Copy link
Collaborator

This needs careful review and run into local machine. Can you add some documentation?

@Bidaya0
Copy link
Contributor Author

Bidaya0 commented Nov 2, 2022

This needs careful review and run into local machine. Can you add some documentation?

ok i will update this branch next week

@safwanrahman
Copy link
Collaborator

@Bidaya0 Hi, Can you add some documentations?

@Bidaya0
Copy link
Contributor Author

Bidaya0 commented May 18, 2023 •
edited

Thanks for remind me, I'll add it

@Bidaya0 Hi, Can you add some documentations?

@Bidaya0
Copy link
Contributor Author

Bidaya0 commented May 21, 2023

Documentations have been added.
@safwanrahman

safwanrahman
safwanrahman reviewed May 23, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@Bidaya0 Bidaya0 requested a review from safwanrahman May 26, 2023 02:30
@Bidaya0
Copy link
Contributor Author

Bidaya0 commented Jun 1, 2023

If you have time, review the revised code, plz.
@safwanrahman

@Bidaya0
Copy link
Contributor Author

Bidaya0 commented Jul 6, 2023 •
edited

@safwanrahman
Hello! Have time to check this out?

@mike-ivs
Copy link

Revisiting this topic 2years later and finding this has made my day! Very keen to see this PR integrated!

@safwanrahman
Copy link
Collaborator

I have finally gone through the code and this looks good. Some minor adjustment need to be made, but I think it is good enough to be merged.
Thanks a lot @Bidaya0 , I am sorry that it took so long to get it merged.
🥳🤩
r+

@safwanrahman safwanrahman merged commit b7d4974 into django-es:master Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safwanrahman safwanrahman safwanrahman approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bidaya0 @safwanrahman @mike-ivs @CorrosiveKid