don't replace . for template dirs in the notes command #1417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a test failure when the generated name from
tmpdir_factory.getbasetemp()
contains a.
.When the notes command processes the apps list, it replaces all
.
with/
and tries to walk the resulting path. This breaks when it encounters a template dir that contains a.
, in which case the resulting path is wrong and can't be found.The new
test_with_template_sub_dirs
test would fail without the change to the notes command that fixes the issue.