Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't replace . for template dirs in the notes command #1417

Merged
merged 2 commits into from Sep 10, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Sep 9, 2019

This change fixes a test failure when the generated name from tmpdir_factory.getbasetemp() contains a ..

When the notes command processes the apps list, it replaces all . with / and tries to walk the resulting path. This breaks when it encounters a template dir that contains a ., in which case the resulting path is wrong and can't be found.

The new test_with_template_sub_dirs test would fail without the change to the notes command that fixes the issue.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 71.339% when pulling 21479c6 on B4dM4n:notes-command into 8bc17b3 on django-extensions:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 71.339% when pulling 21479c6 on B4dM4n:notes-command into 8bc17b3 on django-extensions:master.

@trbs trbs merged commit e30b30c into django-extensions:master Sep 10, 2019
@B4dM4n B4dM4n deleted the notes-command branch September 10, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants