Fix django.contrib.sites detection in set_default_site command when using AppConfig #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing AppConfig in INSTALLED_APPS: django.contrib.sites application can be specified in installed application list either via its module path, or via its AppConfig path. This can be either the default one (django.contrib.sites.apps.SitesConfig), or user-provided AppConfig class. Instead of relying on a fixed name in the settings files, use the application registry to check if the sites application is installed.
trbs
approved these changes
Apr 29, 2021
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to improve
django.contrib.sitesapplication detection in theset_default_sitecommand. Currently the command depends on having the name hardcoded insettings.INSTALLED_APPS, which could lead to not being able to detect the application if it is installed through the AppConfig class/mechanism.Instead of the simple string check, the changed implementation uses application registry.
While not something that is common (I literally found one project that listed the
django.contrib.sites.apps.SitesConfigin its example config), the small fix I propose is probably more robust than the existing one.