Add support for psycopg3 #1814
Merged
Add support for psycopg3 #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really hoping this gets merged soon and I don't have to fork :-/ |
|
+1 This is a pretty big one for Django 4.2 and psycopg3. Haven't been able to update my projects cause I rely pretty heavily on django-extensions. |
|
+1 this is a big leap for the entire project I think! |
|
Thanks ! |
|
Now take find time to make another release 😃 |
|
Just tested with the current main and the drop_test_database command still fails - See #1818 |
ryanchen99
added a commit
to ryanchen99/django-extensions
that referenced
this pull request
May 17, 2023
Add support for psycopg3 (django-extensions#1814)
|
This got merged as-is? Wow. I didn't test it very much. Hoping someone besides me tested it before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django now supports psycopg3. The reset_db and drop_test_database management commands both make calls directly to psycopg2. This means they will not work in a Django project based on psycopg3.
I've never worked on the django-extensions codebase before, so I imagine there is a lot that is wrong with this very simple and straightforward patch attempt. Nonetheless, something is better than nothing. My hope is that even a rejected PR will help this issue get resolved more quickly.
closes #1811