Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking global permissions and row level perms #332

Closed
aidanlister opened this issue Jul 15, 2015 · 4 comments
Closed

Checking global permissions and row level perms #332

aidanlister opened this issue Jul 15, 2015 · 4 comments

Comments

@aidanlister
Copy link

I saw this marked as fixed (#49) but I still need to do my perm checks like this:

if not self.account.has_perm('clients.view_client_dashboard') and not \
    self.account.has_perm('clients.view_client_dashboard', self.instance):

... is that supposed to work that way?

@brianmay
Copy link
Contributor

Sorry, could you please elaborate on the problem? Not sure I understand.

I think that you are claiming that #49 hasn't been fixed, and user.has_perm("perm", obj) is still not checking the global permissions?

Is the correct?

@brianmay
Copy link
Contributor

Unfortunately there is no reference inside #49 to the change that supposedly fixed this.

@brianmay
Copy link
Contributor

Looks like another place where we get confused with global and per object permissions. We need to draft a standard of what should happen, and then stick to it.

@brianmay
Copy link
Contributor

Moving to #380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants