fix 1.8 incompatibility #1167 #1184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix 1.8 incompatibility with deleted db.close_connection() internal API
|
This can't be merged in its current state because it's not compatible with Django 1.7 and earlier. |
|
I'd like to drop support for older versions of Django in the not terribly distant future – maybe just toss in a deprecation warning when we have to fall back to |
This reverts commit c376f2c.
Fix 1.8 incompatibility with deleted db.close_connection() internal API, added backward compatibility with version < 1.8
Fix 1.8 incompatibility with deleted db.close_connection() internal API, added backward compatibility with version < 1.8 (Django warning compliant)
|
The Django 1.8 branch has merged as of bd8e512 |
|
There's a release candidate on PyPI now: pip install django-haystack==2.4.0rc1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 1.8 incompatibility with deleted db.close_connection() internal API. see #1167