Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #iss1509 #1512

Closed
wants to merge 1 commit into from
Closed

Fix #iss1509 #1512

wants to merge 1 commit into from

Conversation

AlvaroLQueiroz
Copy link

No description provided.

@acdha
Copy link
Contributor

acdha commented May 24, 2017

It looks like this will be moot with #1504 which updates build_solr_schema. The tests are failing for the other changes because through at least Django 1.11 Template.render() still requires a Context instance. It looks like the point of confusion was the API change which added pluggable backends which introduced the possibility of get_template or select_template returning something which is not django.template.Template:

https://docs.djangoproject.com/en/1.10/ref/templates/upgrading/#get-template-upgrade-django-18

@acdha acdha closed this May 24, 2017
@AlvaroLQueiroz AlvaroLQueiroz deleted the iss1509 branch July 3, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants