Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1624: SearchQuerySet is instantiated at startup #1625

Merged
merged 1 commit into from Jul 9, 2018
Merged

Fixes #1624: SearchQuerySet is instantiated at startup #1625

merged 1 commit into from Jul 9, 2018

Conversation

batisteo
Copy link
Contributor

@batisteo batisteo commented Jul 4, 2018

No description provided.

acdha
acdha reviewed Jul 4, 2018
View reviewed changes
Copy link
Contributor

@acdha acdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me except that I wanted to check whether we should guard against creating the SearchQuerySet twice by doing an if None test in get_queryset

@batisteo batisteo force-pushed the 1624-searchqueryset-instanciated branch 2 times, most recently from e7946ba to 3c76320 Compare July 5, 2018 09:08
@batisteo batisteo force-pushed the 1624-searchqueryset-instanciated branch from 3c76320 to b607696 Compare July 5, 2018 09:09
@batisteo
Copy link
Contributor Author

batisteo commented Jul 5, 2018

Good one!

I’m removing the queryset = None statement as it’s already part of MultipleObjectMixin.

@acdha acdha merged commit 2831d08 into django-haystack:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdha acdha acdha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@batisteo @acdha