Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use standard Django test runner #1837

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[WIP] Use standard Django test runner #1837

merged 1 commit into from
Apr 12, 2023

Conversation

acdha
Copy link
Contributor

@acdha acdha commented Feb 3, 2022

This is a follow to finish #1834 — I got overeager seeing the “WIP” cleared.

TODO:

  • Remove wait-for-solr script from the other matrix builds
  • Consider adding matrix for other Solr versions (6 is rather old by now)

@claudep
Copy link
Contributor

claudep commented Feb 3, 2022

Do you intend to do the remaining bits yourself, or do you expect me to contribute also? If you have a clear idea of what's missing, I'd appreciate your final touch :-)

@acdha
Copy link
Contributor Author

acdha commented Feb 3, 2022

I'll take a stab at it over the weekend.

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss
Copy link
Contributor

cclauss commented Nov 21, 2022

It would be great to see progress on this or a migration towards pytest-django

@claudep
Copy link
Contributor

claudep commented Apr 7, 2023

@acdha, @cclauss, Should we push this PR in its current state? Or are TODOs mandatory to go ahead? Unless something is done soon, the project should then be declared as dead.

@cclauss
Copy link
Contributor

cclauss commented Apr 7, 2023

My sense is that this is ready to land as is.

@acdha acdha merged commit 62e6fee into master Apr 12, 2023
@acdha
Copy link
Contributor Author

acdha commented Apr 12, 2023

@claudep I think you're right that we should merge it. Longer term, Haystack could really use new maintainers. I decommissioned the project I primarily used it on a couple of years ago and my spare time is pretty limited these days. I've been thinking about discussing it with Jazzband to see if we could turn everything in this organization over. If you have any advice, I'd be interested in your opinion.

@acdha acdha deleted the remove_nose branch April 12, 2023 14:47
@cclauss
Copy link
Contributor

cclauss commented Apr 12, 2023

Your reviews please on #1855

@claudep
Copy link
Contributor

claudep commented Apr 12, 2023

Moving to Jazzband could be a good thing, but this will not automagically add new maintainers. I'd suggest opening a ticket to collect any interested future maintainers, and then the new team, if any, could help to move to Jazzband.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants