Fix flake8: logging.error(exc_info=True) --> logging.exception() #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
fix-flake8
branch
2 times, most recently
from
3e2629d
to
30fddf0
Compare
cclauss
changed the title
claudep
reviewed
Nov 21, 2022
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| def update_worker(args): | |||
| if len(args) != 10: | |||
| LOG.error("update_worker received incorrect arguments: %r", args) | |||
| LOG.exception("update_worker received incorrect arguments: %r", args) | |||
There was a problem hiding this comment.
Shouldn't this be kept as an error logging? At logging time, the exception will not yet be raised, right?
There was a problem hiding this comment.
Good eyes!! Reverted
claudep
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for contributing to Haystack. Please review the contributor guidelines and confirm that the tests pass with at least one search engine.
Once your pull request has been submitted, the full test suite will be executed on https://github.com/django-haystack/django-haystack/actions/workflows/test.yml. Pull requests with passing tests are far more likely to be reviewed and merged.
Placate https://github.com/globality-corp/flake8-logging-format