PEP 621: Migrate from setup.py and setup.cfg to pyproject.toml #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally, it would be nice to first fix the test suite before continuing modernizing linting/building. What do you think? |
cclauss
force-pushed
the
more-pyproject.toml
branch
from
cbaf045
to
31989ef
Compare
cclauss
force-pushed
the
more-pyproject.toml
branch
from
ced2e12
to
75ccb2c
Compare
cclauss
force-pushed
the
more-pyproject.toml
branch
from
75ccb2c
to
bf2f967
Compare
cclauss
force-pushed
the
more-pyproject.toml
branch
from
063f60a
to
5c05572
Compare
claudep
reviewed
Apr 29, 2024
.github/workflows/test.yml
Outdated
| @@ -63,7 +63,8 @@ jobs: | |||
| python -m pip install --upgrade pip setuptools wheel | |||
| pip install coverage requests tox tox-gh-actions | |||
| pip install django==${{ matrix.django-version }} elasticsearch==${{ matrix.elastic-version }} | |||
| python setup.py clean build install | |||
| # python setup.py clean build install | |||
There was a problem hiding this comment.
Do you intend to keep this commented line?
| @@ -20,8 +20,8 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: # https://docs.djangoproject.com/en/stable/faq/install/#what-python-version-can-i-use-with-django | |||
| django-version: ["3.2", "4.2", "5.0"] | |||
| python-version: ["3.8", "3.9"] # , "3.10", "3.11", "3.12"] # Whoosh issues with Py3.10+ | |||
| django-version: ["3.2", "4.2"] # , "5.0"] | |||
There was a problem hiding this comment.
For what reason did you have to remove "5.0" from the matrix?
There was a problem hiding this comment.
It currently fails.
There was a problem hiding this comment.
Oh yes, sorry, I forgot it was also excluded on current master.
cclauss
commented
Apr 29, 2024
claudep
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
setup.pytosetup.cfgusing setuptools-py2cfg plus manual modifications. Then migratesetup.cfgtopyproject.tomlusing ini2toml to do the file conversion and running pyproject-fmt and then validate-pyproject in pre-commit to validate the results.