Support for nested documents #170
Conversation
|
Added NESTED_DOC_KEY='childDocuments' instead of hardcoded 'children' to match nested documents. Maybe this is a sensible default since it matches Solr's naming. So all is good now. Haystack support for nested documents on Solr and Elastic coming up :) |
|
bump |
|
@acdha bump. |
|
+1 Would be nice to have this in there. |
|
Can this be given a higher priority? I'm maintaining my own fork for this (https://github.com/ahankinson/pysolr/tree/fix-child-documents). I'd be happy to contribute it as a new pull request, but support for the |
This adds support for Solr's nested documents in `Solr.add` Thanks to @skirsdeda for the patch
This adds support for Solr's nested documents in `Solr.add` Thanks to @skirsdeda for the patch
|
@ahankinson Since @skirsdeda sent a nice clean patch, it wasn't hard to update against the current master. The tests are running now: https://travis-ci.org/acdha/pysolr/builds/140901856 |
|
fantastic, thank you very much. |
This makes it possible to add nested documents (documents with children) via Solr.add. Includes tests as well, however {!child} query seems to be buggy in 4.10 so I left it disabled.
One thing worth discussing is the children key in doc dicts. I simply used "children" but maybe some safer option could be used (like 'children' or 'childDocuments' as in Solr's JSON request handler) so that it doesn't accidentally clash with simple fields.