Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ChangeLog note about default commit policy #241

Merged
merged 1 commit into from Oct 3, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.rst
Expand Up @@ -47,6 +47,20 @@ Changes
removes the __del__ methods and we will have to find an alternative for
making tests fail safely.

- Custom Commit Policy . [Evan Fagerberg]

Previously a ``Solr`` object assumed that an operation should commit by default.
It is generally good practice to limit the amount of commits to solr.
Excessive commits risk opening too many searcher or using too many system resources.
Therefore the commit policy is configurable via the ``always_commit`` attribute of
the ``Solr`` object.

Most solr configurations should already have an interval that defines how long to wait
before doing a commit to solr anyway. (Measured either in time or number of documents)

IMPORTANT: If you are upgrading to this version and need to keep committing by default,
change the Solr objects to have ``always_commit=True``.

Fix
~~~

Expand Down