Skip to content

Commit

Permalink
Bug in test_per_queue_staff_permission.py
Browse files Browse the repository at this point in the history
Using the django auth backend allows integers to be passed as a password
Using Peter Sagerson's ldap auth backend there is an error thrown because
some code tries to do a len() on the password.
You could argue that the ldap auth backend should str(password), but
you could also argue that passing an int as a password is bad practice

This PR ensures that a string is sent to the auth module.
  • Loading branch information
Daryl committed Jun 30, 2016
1 parent afbfd01 commit 44bbcd3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions helpdesk/tests/test_per_queue_staff_permission.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def setUp(self):
username='User_%d' % identifier,
is_staff=True,
)
user.set_password(identifier)
user.set_password(str(identifier))
user.save()

# The prefix 'helpdesk.' must be trimmed
Expand Down Expand Up @@ -74,7 +74,7 @@ def test_dashboard_ticket_counts(self):

# Regular users
for identifier in self.IDENTIFIERS:
self.client.login(username='User_%d' % identifier, password=identifier)
self.client.login(username='User_%d' % identifier, password=str(identifier))
response = self.client.get(reverse('helpdesk_dashboard'))
self.assertEqual(
len(response.context['unassigned_tickets']),
Expand Down Expand Up @@ -131,7 +131,7 @@ def test_ticket_list_per_queue_user_restrictions(self):
"""
# Regular users
for identifier in self.IDENTIFIERS:
self.client.login(username='User_%d' % identifier, password=identifier)
self.client.login(username='User_%d' % identifier, password=str(identifier))
response = self.client.get(reverse('helpdesk_list'))
self.assertEqual(
len(response.context['tickets']),
Expand Down Expand Up @@ -166,7 +166,7 @@ def test_ticket_reports_per_queue_user_restrictions(self):
"""
# Regular users
for identifier in self.IDENTIFIERS:
self.client.login(username='User_%d' % identifier, password=identifier)
self.client.login(username='User_%d' % identifier, password=str(identifier))
response = self.client.get(
reverse('helpdesk_run_report', kwargs={'report': 'userqueue'})
)
Expand Down

0 comments on commit 44bbcd3

Please sign in to comment.