Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 'NoneType' object has no attribute 'email' #808

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

ilikerobots
Copy link
Contributor

Fixes #807

@gwasser
Copy link
Member

gwasser commented Mar 18, 2020

Thank you! Hmm, any thoughts why the tests fail on Python 2?

@ilikerobots
Copy link
Contributor Author

Not sure, actually. I tried in my own env and everything passes (see log below). It's odd though, the error is in the CC handling test which makes me think it might be legit. However, the error seems to be involving date handling.

(django-helpdesk) $ python2.7 --version
Python 2.7.17
(django-helpdesk) $ git branch 
  master
* patch-2
(django-helpdesk) $ python2.7  quicktest.py helpdesk
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
.................................................................
----------------------------------------------------------------------
Ran 65 tests in 2.705s

OK
Destroying test database for alias 'default'...

@ilikerobots
Copy link
Contributor Author

ilikerobots commented Apr 15, 2020

Hi, regarding the test failure, I don't think it has anything to do with the change in this PR.
I triggered a build with just a text change and it fails in exactly the same way: https://travis-ci.org/github/ilikerobots/django-helpdesk

I think it's an issue with python-tzlocal, probably related to this: https://bugzilla.redhat.com/show_bug.cgi?id=1295709/

@ilikerobots
Copy link
Contributor Author

I created a fix for the test failure here: #813

@gwasser
Copy link
Member

gwasser commented Apr 15, 2020

Sounds good thanks!

@gwasser gwasser merged commit b9933a8 into django-helpdesk:0.2.x Apr 15, 2020
@gwasser gwasser added this to the 0.2.20 milestone Apr 15, 2020
@gwasser gwasser added the bug Something isn't working or is broken label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants