TypeError when releasing when LOGOUT_REDIRECT_URL is None

[LincolnPuzey]

According to the Django docs LOGOUT_REDIRECT_URL can be set to None

https://docs.djangoproject.com/en/dev/ref/settings/#logout-redirect-url

When this is the case a TypeError can be raised here in the release view

Because self.success_url == LOGOUT_REDIRECT_URL == None

Passing None to resolve_url causes a TypeError

[Mogost]

None is not allowed for LOGIN_REDIRECT_URL in django.

[LincolnPuzey]

My bad I got login/logout mixed up when writing the issue. I have edited to be correct. LOGOUT_REDIRECT_URL is the setting being used that can be None

[codingjoe]

Hi @LincolnPuzey,

Again, welcome and nice you are digging up all those hidden little issues. I am curious, you must have a rather large and well-integrated application running on our humble little framework. That's wonderful!

Regarding the issue at hand. I looked into it, and it seems Django would render a logout screen if the LOGOUT_REDIRECT_URL setting is set to None.

Tho this behavior could be implemented, the original LogoutView isn't easily adjusted, and I don't like the idea of creating a carbon copy that we need to maintain and keep up to date with the Django implementation. After all, the smaller this library remains, the less likely is it to include security wholes.

Therefore, my solution would be to simply fall back to / if the LOGOUT_REDIRECT_URL is set to None and no explicit next value is given.

Before I go ahead and make the change, though, I'd really like to get your feedback on this.

Best Joe

[LincolnPuzey]

Falling back to / seems sensible to me 👍