Fix #527 -- HijackUserAdminMixin: handle cases in which ForeignKey to User is not set #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingjoe
reviewed
Jan 5, 2023
|
@codingjoe is that what you had in mind? |
codingjoe
reviewed
Feb 6, 2023
handle hijacked==None and prevent error 500 resolves django-hijack#527 Revert "condition replaced by exception handling in permission checks" This reverts commit 922b498.
|
@codingjoe any further changes you want me to do? |
Nothing except sponsoring my maybe, so I find more time for OSS 🤣 In all seriousness, I will try to review it today. |
codingjoe
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.