Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese language translation #550

Merged
merged 2 commits into from Mar 15, 2023
Merged

Add Japanese language translation #550

merged 2 commits into from Mar 15, 2023

Conversation

Kumamoto-Hamachi
Copy link
Contributor

@Kumamoto-Hamachi Kumamoto-Hamachi commented Mar 14, 2023 •
edited

Hi all, I have made the Japanese localisation change in this PR.
Please review the changes. 🙏

How I make django.po file

$ cd /your/path/django-hijack
$ django-admin makemessages -l ja -e html -e py

@codingjoe
Copy link
Collaborator

Hello again. I see now, you opened another pull-requst. Excellent! Please let me know once you are ready for a review. Best Joe!

@Kumamoto-Hamachi Kumamoto-Hamachi marked this pull request as ready for review March 14, 2023 23:15
codingjoe
codingjoe reviewed Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I can only say things like "where is the convenience store" and "Like'd like a hot coffee" in Japanese, I can't do much of a review. All I can say is: ありがとう 😜

hijack/locale/ja/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
@codingjoe codingjoe merged commit 17c7189 into django-hijack:master Mar 15, 2023
@Kumamoto-Hamachi Kumamoto-Hamachi deleted the feature/jp-localication branch March 15, 2023 13:44
@codingjoe
Copy link
Collaborator

Thanks again @Kumamoto-Hamachi. Version 3.3.0 comes with Japanese translations now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingjoe codingjoe Awaiting requested review from codingjoe

Assignees

@Kumamoto-Hamachi Kumamoto-Hamachi

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kumamoto-Hamachi @codingjoe