Avoid calling Field.clean() unnecessarily twice

django-import-export · Nov 24, 2017 · 52a8c51 · 52a8c51
1 parent 688034a
commit 52a8c51
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/import_export/fields.py b/import_export/fields.py
@@ -112,8 +112,9 @@ def save(self, obj, data):
             attrs = self.attribute.split('__')
             for attr in attrs[:-1]:
                 obj = getattr(obj, attr, None)
-            if self.clean(data) != None or self.saves_null_values:
-                setattr(obj, attrs[-1], self.clean(data))
+            cleaned = self.clean(data)
+            if cleaned is not None or self.saves_null_values:
+                setattr(obj, attrs[-1], cleaned)
 
     def export(self, obj):
         """