fix for cache entries not removed (#1621)

* fix for cache entries not removed * updated changelog
django-import-export · Sep 13, 2023 · 9820009 · 9820009
1 parent 15e4267
commit 9820009
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -10,6 +10,7 @@ Changelog
 - Removed reference to tablib dev from tox build (#1603)
 - Add customizable blocks in import.html (#1598)
 - Updated ru translation (#1604)
+- Fix for cache entries not removed (#1621)
 - Fixed badly formatted translation string (#1622)
 - Add kwargs to enable CharWidget to return values as strings (#1623)
 - Updated documentation for interoperability with third party libraries (#1614)

diff --git a/import_export/tmp_storages.py b/import_export/tmp_storages.py
@@ -64,7 +64,7 @@ def read(self):
         return cache.get(self.CACHE_PREFIX + self.name)
 
     def remove(self):
-        cache.delete(self.name)
+        cache.delete(self.CACHE_PREFIX + self.name)
 
 
 class MediaStorage(BaseStorage):

diff --git a/tests/core/tests/test_tmp_storages.py b/tests/core/tests/test_tmp_storages.py
@@ -75,9 +75,9 @@ def test_cache_storage(self):
         tmp_storage = CacheStorage(name=name)
         self.assertEqual(self.test_string, tmp_storage.read())
 
-        self.assertNotEqual(cache.get(tmp_storage.CACHE_PREFIX, tmp_storage.name), None)
+        self.assertIsNotNone(cache.get(tmp_storage.CACHE_PREFIX + tmp_storage.name))
         tmp_storage.remove()
-        self.assertEqual(cache.get(tmp_storage.name), None)
+        self.assertIsNone(cache.get(tmp_storage.CACHE_PREFIX + tmp_storage.name))
 
     def test_cache_storage_read_with_encoding(self):
         tmp_storage = CacheStorage()