Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about support dark mode style when importing from admin pages #1318

Closed
clichedmoog opened this issue Aug 24, 2021 · 5 comments
Closed

How about support dark mode style when importing from admin pages #1318

clichedmoog opened this issue Aug 24, 2021 · 5 comments
Assignees
Labels

Comments

@clichedmoog
Copy link

clichedmoog commented Aug 24, 2021

Describe the bug
This is a suggestion rather than a bug, so everything works fine, except the design:
When using dark mode, the import confirmation view does not display properly

To Reproduce
Steps to reproduce the behavior:

  1. Apply admin using ImportMixin, ImportExportMixin or ImportExportModelAdmin
  2. Click the 'import' button from the admin view from step 1
  3. Select importing file, and format of the file
  4. After clicking the 'submit' button, you can see the import confirmation view
  5. When using dark mode, and from the view in step 4, you hardly see the import details.

Versions (please complete the following information):

  • Django Import Export: 2.5.0
  • Python 3.9.6
  • Django 3.2.5

Expected behavior
The import details should see easily when using dark mode

Screenshots
스크린샷 2021-08-25 오전 4 25 48

Additional context
Please refer: https://developer.mozilla.org/docs/Web/CSS/@media/prefers-color-scheme

@clichedmoog
Copy link
Author

clichedmoog commented Aug 24, 2021

If you see the same view in the light mode it can view easily:
스크린샷 2021-08-25 오전 4 25 30

@clichedmoog clichedmoog changed the title How about dark mode How about support dark mode style Aug 24, 2021
@clichedmoog clichedmoog changed the title How about support dark mode style How about support dark mode style when importing from admin pages Aug 24, 2021
@matthewhegarty matthewhegarty self-assigned this Aug 26, 2021
matthewhegarty added a commit to matthewhegarty/django-import-export that referenced this issue Aug 28, 2021
matthewhegarty added a commit that referenced this issue Aug 30, 2021
striveforbest pushed a commit to striveforbest/django-import-export that referenced this issue Oct 14, 2021
@matthewhegarty
Copy link
Contributor

Had to roll this back because it caused issues in django2.2

@cl33per
Copy link

cl33per commented Mar 23, 2022

Still experiencing an issue with dark mode.

Browser Google Chrome.

$pip show django-import-export
Name: django-import-export
Version: 2.7.1
Summary: Django application and library for importing and exporting data with included admin integration.
Home-page: https://github.com/django-import-export/django-import-export
Author: Informatika Mihelac
Author-email: bmihelac@mihelac.org
License: BSD License
Location: /usr/local/lib/python3.9/site-packages
Requires: diff-match-patch, Django, tablib

image

@matthewhegarty
Copy link
Contributor

Will be addressing this in the next release - hopefully soon

matthewhegarty added a commit to matthewhegarty/django-import-export that referenced this issue Mar 30, 2022
@matthewhegarty
Copy link
Contributor

released in 2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants