add row_number parameter to before_import_row, after_import_row and after_import_instance #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter_import_instance
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hey all! This seems like a good addition to me. @andrewgy8 you noted that @PetrDlouhy's original #1040 didn't have tests, and this version does. What do you think about this one (after the changeling entries are updated of course)? |
andrewgy8
approved these changes
May 21, 2020
There was a problem hiding this comment.
Agreed. I just fixed the conflicts, so it should all be good! Ill wait for the CI to pass, and then merge. Thanks @timthelion and @mgrdcm !
ZuluPro
pushed a commit
to ZuluPro/django-import-export
that referenced
this pull request
Dec 23, 2020
…fter_import_instance (django-import-export#1040) Co-authored-by: Petr Dlouhý <petr.dlouhy@email.cz> Co-authored-by: Andrew Graham-Yooll <andrewgy8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #1002 and includes a test.