Expand valid values for BooleanWidget #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deals better with NULL/None values, which are now (Django 2.2) permitted in the regular fields.BooleanField (fields.NullBooleanField has been deprecated). Importing a field with TRUE/FALSE/NULL was otherwise failing (and turning all the NULL's into FALSE's).
MinchinWeb
force-pushed
the
boolean-widget
branch
from
1e83e95
to
2fb0213
Compare
andrewgy8
requested changes
Jan 27, 2020
There was a problem hiding this comment.
Thanks @MinchinWeb for the PR! Do you mind adding some docs and tests for this change?
MinchinWeb
force-pushed
the
boolean-widget
branch
from
643ad97
to
212f557
Compare
|
@andrewgy8 : docs and tests added! |
|
Is anything holding this up? |
|
@MinchinWeb There are some conflicts that need to be resolved. |
Closed
andrewgy8
approved these changes
May 28, 2020
andrewgy8
changed the title
|
Thanks @MinchinWeb ! |
|
Ill try to have this in the next minor release asap. |
manelclos
changed the title
ZuluPro
pushed a commit
to ZuluPro/django-import-export
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals better with NULL/None values, which are now (Django 2.2) permitted in the regular fields.BooleanField (fields.NullBooleanField has been deprecated). Importing a field with TRUE/FALSE/NULL was otherwise failing (via turning all the NULL's into FALSE's).
Problem
The Boolean widget (which is used to diff an re-import) wasn't dealing with Null/None/Empty values, and instead casting them as "0" (i.e.
False)Solution
Explicitly add
""(an empty string) andNoneas "None values".Acceptance Criteria
Have you written tests? Have you included screenshots of your changes if applicable?
Did you document your changes?
No additional tests. No screenshot. I've added it to the Changelog (under v2.0.2).