Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'requirements' section from README.rst #1114

Conversation

matthewhegarty
Copy link
Contributor

Problem

Project requirements were defined in README.rst. This is unnecessary because the requirements are enforced in setup.py. See #1079

Solution

Removed this section entirely.

Acceptance Criteria

Simple text change so review should be acceptable.

Copy link
Member

@andrewgy8 andrewgy8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps we can add a badge.io for the supported python versions in the future.

@matthewhegarty matthewhegarty force-pushed the remove-dependencies-from-readme branch from 1468c60 to eb908df Compare April 26, 2020 17:22
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.216% when pulling eb908df on matthewhegarty:remove-dependencies-from-readme into e714a6b on django-import-export:master.

@andrewgy8 andrewgy8 changed the title removed 'requirements' section from README.rst Removed 'requirements' section from README.rst Apr 27, 2020
@andrewgy8 andrewgy8 merged commit ebeea24 into django-import-export:master Apr 27, 2020
@matthewhegarty matthewhegarty deleted the remove-dependencies-from-readme branch April 29, 2020 13:46
ZuluPro pushed a commit to ZuluPro/django-import-export that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants