Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test Django main branch using python36,37 #1269

Merged
merged 1 commit into from Apr 16, 2021
Merged

Conversation

manelclos
Copy link
Contributor

Problem

Travis is trying to run tests using python36,37 against Django main, which only supports python38,39

Solution

Exclude from matrix

Acceptance Criteria

Tests should pass now

@manelclos manelclos force-pushed the fix-travis-tests branch 5 times, most recently from e66ddd4 to 51447cc Compare April 16, 2021 14:49
@coveralls
Copy link

coveralls commented Apr 16, 2021

Coverage Status

Coverage remained the same at 96.757% when pulling dd5f0ce on fix-travis-tests into 8e6c0e6 on master.

@manelclos manelclos force-pushed the fix-travis-tests branch 4 times, most recently from 1da8f7c to 10f8926 Compare April 16, 2021 15:02
@andrewgy8
Copy link
Member

Thanks @manelclos ! I would really like to move to github actions soon. This travis build takes farrrr too long.

@manelclos
Copy link
Contributor Author

manelclos commented Apr 16, 2021

@andrewgy8 great, I was going to ask that next, but wanted to fix travis to pass cleanly. Just pushed the last update.

@manelclos
Copy link
Contributor Author

@andrewgy8 tests passed, merging this one. Django main seems to be failing, probably due to postgresql support:

https://github.com/django/django/blob/76c0b32f826469320c59709d31e2f2126dd7c505/django/db/backends/postgresql/introspection.py#L51

https://docs.djangoproject.com/en/dev/ref/databases/#postgresql-notes

We should take care of that when moving to GitHub actions. I don't have much time now. Do you plan to take on it?

@manelclos manelclos merged commit e8e7548 into master Apr 16, 2021
@manelclos manelclos deleted the fix-travis-tests branch April 16, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants