Fix minor date formatting issue for date with years < 1000 #1285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a minor bug in
DateWidget
andDateTimeWidget
where dates with years < 1000 are not formatted with 4 digits.This is a minor issue but is a bug that may affect anyone exporting data with historic dates.
4 digit years are OK
<4 digit years don't render with leading zeroes
Before fix
After fix
Solution
This PR fixes that by using the
datetime_safe
module in DjangoThere was an earlier fix to address dates before 1900, which was a previous issue in Django, however that fix did not address this bug. Also that fix applied only to
DateWidget
and notDateTimeWidget
.The original Django issue was updated once python2 was unsupported.
Acceptance Criteria
widgets.py
coverage to 100%