Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased test coverage #1286

Merged

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented May 4, 2021

Problem

Code coverage showed some gaps in testing. I've increased this where possible.

Solution

  • Added unit tests as required
  • No functional changes have been made
  • Also fixed 'lint' command in Makefile

Note that test_collect_failed_rows() was included in the 'postgres' section, hence didn't run in non-PG env. I moved this to the 'general' test section so that it will run.

Acceptance Criteria

  • test suite passes

@coveralls
Copy link

coveralls commented May 4, 2021

Coverage Status

Coverage increased (+0.9%) to 98.796% when pulling 8790738 on matthewhegarty:improve-code-coverage into 4167a16 on django-import-export:main.

Copy link
Member

@andrewgy8 andrewgy8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic @matthewhegarty !

@andrewgy8 andrewgy8 changed the title increased test coverage Increased test coverage May 5, 2021
@andrewgy8 andrewgy8 merged commit 01ab025 into django-import-export:main May 5, 2021
@matthewhegarty matthewhegarty deleted the improve-code-coverage branch August 9, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants