Use Github secret in CI script instead of hard-coded password #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
force-pushed
the
add-ci-secret
branch
from
6247ff3
to
3cb96fb
Compare
matthewhegarty
force-pushed
the
add-ci-secret
branch
from
3cb96fb
to
f6bad89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A minor improvement to the CI script.
The CI script was using a hard-coded password which is not ideal. Best practice is to use a secret defined in Github.
Solution
The CI script now uses a Github secret instead of a hard-coded password.
Acceptance Criteria
Verified that the CI process ran ok, meaning the change is valid.