Use 'create' flag instead of instance.pk (#1274) #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
force-pushed
the
use-create-flag-instead-of-instance-pk
branch
from
412f6e0
to
0bd2d8a
Compare
Closed
changed 'is_create' to mandatory arg added 'pk_attr' property reverted self.save_instance() call params added tests for UUID model field fixed test_resources.py imports added is_create flag refactored migration name removed django_extensions from settings documented breaking change in changelog removed unused pk_attr attribute fixed indentation
matthewhegarty
force-pushed
the
use-create-flag-instead-of-instance-pk
branch
from
4588f3e
to
40b44a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
(issue #1274)
For bulk creates / updates, the instance.pk field was being used to determine whether a bulk update or create should be performed. This doesn't work when pk is dynamically generated (e.g. UUID).
This was originally reviewed in #1278, but that PR was closed when I force pushed following rebase 馃う
Solution
This fix uses the 'new' value returned from get_or_init_instance(), and passes this in as a kwarg to save_instance(). Hence the check against instance.pk is not required.
This will be an API breaking change.
Acceptance Criteria