New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve test coverage #1372
Merged
matthewhegarty
merged 1 commit into
django-import-export:release-3-x
from
matthewhegarty:test-coverage-update
Dec 29, 2021
Merged
improve test coverage #1372
matthewhegarty
merged 1 commit into
django-import-export:release-3-x
from
matthewhegarty:test-coverage-update
Dec 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
added a commit
to matthewhegarty/django-import-export
that referenced
this pull request
Dec 26, 2021
matthewhegarty
force-pushed
the
test-coverage-update
branch
from
December 26, 2021 22:56
76fe540
to
58fe389
Compare
matthewhegarty
added a commit
to matthewhegarty/django-import-export
that referenced
this pull request
Dec 27, 2021
matthewhegarty
force-pushed
the
test-coverage-update
branch
from
December 27, 2021 16:19
b9af182
to
fc28e02
Compare
matthewhegarty
added a commit
to matthewhegarty/django-import-export
that referenced
this pull request
Dec 27, 2021
matthewhegarty
force-pushed
the
test-coverage-update
branch
from
December 27, 2021 21:05
fc28e02
to
cf4e0f7
Compare
matthewhegarty
added a commit
to matthewhegarty/django-import-export
that referenced
this pull request
Dec 27, 2021
matthewhegarty
force-pushed
the
test-coverage-update
branch
from
December 27, 2021 21:15
cf4e0f7
to
96deb6e
Compare
matthewhegarty
added a commit
to matthewhegarty/django-import-export
that referenced
this pull request
Dec 28, 2021
matthewhegarty
force-pushed
the
test-coverage-update
branch
from
December 28, 2021 19:06
ad949a6
to
b4b50ac
Compare
matthewhegarty
added a commit
to matthewhegarty/django-import-export
that referenced
this pull request
Dec 29, 2021
matthewhegarty
force-pushed
the
test-coverage-update
branch
from
December 29, 2021 13:11
3cef2b0
to
84a2065
Compare
manelclos
reviewed
Dec 29, 2021
@manelclos many thanks for reviewing - I've added some comments and made some changes |
manelclos
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matthewhegarty
force-pushed
the
test-coverage-update
branch
from
December 29, 2021 18:19
9787d74
to
0bbdba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For inclusion in Release 3
Code coverage seems to miss certain paths, meaning coverage is lower than it should be.
This is because the
IMPORT_EXPORT_TEST_TYPE
env var is not being set correctly for test runs, which means that postgres / mysql specific tests are not being run as part of the CI process.Solution
I switched the CI script to use tox instead of the github actions matrix. This is a better approach because tox is already present in the project, though not being used during CI.
settings.py
).exceptions.py
module (and added appropriate test)tests
runtests.sh
- now will run tox tests for each supported db (sqlite, postgres, MySQL)testing.rst
docker-compose.yml
to support testingAcceptance Criteria