Fix crash on import_data(Dataset(), collect_failed_rows=True)
#1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
changed the title
import_data(Dataset(), collect_failed_rows=Trueimport_data(Dataset(), collect_failed_rows=True)
pokken-magic
approved these changes
Jan 22, 2022
matthewhegarty
force-pushed
the
collect-failed-rows-crash
branch
from
552f7c1
to
15d38b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
import_data()crashes when passed an empty dataset andcollect_failed_rowsis True.See #1380
Solution
Add check for
headers is Noneand create empty list if so.Acceptance Criteria