Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add get export form to export mixin #1409

Conversation

KamilRizatdinov
Copy link
Contributor

Problem

What problem have you solved?

You can see how hard it is to use the custom export form. You have to override the whole export_action() method.
https://stackoverflow.com/a/67653671/17465982 referes to this problem as well

Solution

How did you solve the problem?

Introduced the get_export_form() method on ExportMixin as an analogue to get_import_form() from ImportMixin

Acceptance Criteria

Have you written tests? Have you included screenshots of your changes if applicable?
Did you document your changes?

Yes, I've written the test cases to ensure that both the base functionality and functionality work
I used the docstrings for the get_export_form() method, think that's a sufficient documentation

@matthewhegarty
Copy link
Contributor

Thanks for this. Please could you add the following to the changelog:

add get_export_form() to ExportMixin (#1409)

Please could you also squash the commits into one and push.
Feel free to add your name to AUTHORS.

@KamilRizatdinov KamilRizatdinov force-pushed the feat_add_get_export_form_to_export_mixin branch from 71305e0 to 4edcf47 Compare March 31, 2022 14:13
@KamilRizatdinov
Copy link
Contributor Author

Thanks for this. Please could you add the following to the changelog:

add get_export_form() to ExportMixin (#1409)

Please could you also squash the commits into one and push. Feel free to add your name to AUTHORS.

All done!

@coveralls
Copy link

coveralls commented Mar 31, 2022

Coverage Status

Coverage increased (+0.003%) to 98.394% when pulling 227de9c on KamilRizatdinov:feat_add_get_export_form_to_export_mixin into 8d6e46f on django-import-export:main.

@matthewhegarty matthewhegarty merged commit b293c83 into django-import-export:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants