Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure when CacheStorage enabled and file contains LF char #1417

Merged
merged 2 commits into from Apr 9, 2022
Merged

Fix failure when CacheStorage enabled and file contains LF char #1417

merged 2 commits into from Apr 9, 2022

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented Apr 9, 2022 •
edited

Problem

#1397 Imports fail when CacheStorage is enabled and the file contains LF char.

Solution

This was an issue in tablib which was fixed in release 3.2.1.
This means that django-import-now requires tablib 3.2.1 as a minimum dependency.

Acceptance Criteria

  • Integration tests are included which verifies the fix.
  • Manually tested steps to reproduce from issue

@matthewhegarty matthewhegarty changed the base branch from main to release-3-x April 9, 2022 17:23
@matthewhegarty matthewhegarty merged commit d3d43ec into django-import-export:release-3-x Apr 9, 2022
@matthewhegarty matthewhegarty deleted the issue-1397-LF-tablib-issue branch April 9, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@matthewhegarty