Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files generated when running tox locally #1426

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented Apr 21, 2022

Problem

Fixes issue #1424
Coverage files and 'response.html' get generated when running locally

Solution

  • Removed the unused write to response.html
  • Added an Env var which gets set in CI only, and which indicates that coverage data should be generated.
  • Added a new script runtests.py which adds the COVERAGE env var if present

Acceptance Criteria

  • Tested locally
  • Tested in CI

@matthewhegarty matthewhegarty changed the base branch from main to release-3-x April 21, 2022 10:44
Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude thanks so much for doing this and for knowing all this minutiae that makes things flow.

@matthewhegarty matthewhegarty merged commit 40f1445 into django-import-export:release-3-x Apr 21, 2022
@matthewhegarty matthewhegarty deleted the fix-tox-files-1424 branch April 21, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants