[3.0] Improve import form compatibility #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @matthewhegarty, something like this would make the upgrade to 3.0 a bit easier. Please let me know what you think. |
manelclos
changed the title
matthewhegarty
requested changes
May 12, 2022
|
@manelclos shall I write some tests to get this over the line? |
|
@matthewhegarty working on this today, lets see how much I can get done. |
|
working on the test, feel free to correct the breaking changes note I just added. |
|
Hi @matthewhegarty tests just added. Let me know what you think. I'll squash commits before merge. |
matthewhegarty
approved these changes
May 17, 2022
|
Yes, after using the new base class everything works as expected. |
manelclos
force-pushed
the
manelclos/improve-importform-compatibility
branch
from
c9abcc6
to
3f21c2f
Compare
|
squashed, ready for merge |
matthewhegarty
deleted the
manelclos/improve-importform-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1432
Avoid crashing and print a warning about what needs to be changed to get it fully working in 3.0