Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation: Added support for transitional form renderer #1451

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented Jun 13, 2022

Problem

Fixes #1449. This affects the example application only.

There is a form template in the test app (category_list.html). This uses a {{ form }} tag. For django 4.1 this means that there has to be a declaration of the form renderer to use.

Solution

This change adds a conditional FormRenderer to test settings when the Django version is 4.1.

Acceptance Criteria

form_after.html.txt
form_before.html.txt

@coveralls
Copy link

coveralls commented Jun 13, 2022

Coverage Status

Coverage remained the same at 98.394% when pulling 8c023f4 on matthewhegarty:issue-1449-transitional-renderer into 033f803 on django-import-export:main.

Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me. Thanks.

Copy link
Contributor

@manelclos manelclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@matthewhegarty matthewhegarty merged commit eb27821 into django-import-export:main Jun 13, 2022
@matthewhegarty matthewhegarty deleted the issue-1449-transitional-renderer branch February 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox build fails on django main
4 participants