Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply make_aware when the original file contains actual datetimes #1478

Merged

Conversation

vanschelven
Copy link
Contributor

...rather than strings

Fix #1165

@coveralls
Copy link

coveralls commented Jul 27, 2022

Coverage Status

Coverage increased (+0.002%) to 98.396% when pulling 8f96cfc on vanschelven:fix-datetime-use-tz into 2c1dac5 on django-import-export:main.

@matthewhegarty
Copy link
Contributor

Please can you add a unit test to prove that your change solves the issue.
Also you can close the duplicate PR, we'll merge this change into the release 3 branch once it's gone into main.
thanks

@matthewhegarty
Copy link
Contributor

hi @vanschelven Thanks so much for reporting and fixing this issue, it has been around for a while so it is great to get it resolved. I hope you don't mind but I refactored slightly to remove some minor duplication. See what you think. If you are OK with it I will merge soon.

@vanschelven
Copy link
Contributor Author

LGTM

@matthewhegarty matthewhegarty merged commit a0b4dfc into django-import-export:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datetime field localtime() issue
3 participants