New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix escaping to support escape of XLSX formulae #1568
Merged
matthewhegarty
merged 14 commits into
django-import-export:main
from
matthewhegarty:1543-xlsx-vuln
Apr 6, 2023
Merged
Fix escaping to support escape of XLSX formulae #1568
matthewhegarty
merged 14 commits into
django-import-export:main
from
matthewhegarty:1543-xlsx-vuln
Apr 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort-export into 1543-xlsx-vuln
I have tested all 3 parameters to all formats and everything looks Ok. |
pokken-magic
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a cool, boring, totally nonsexy but deceptively important bit of code. Appreciate you doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #1543. Security vulnerabilities present due to not escaping potentially malicious content.
Solution
I have introduced two new settings attributes:
IMPORT_EXPORT_ESCAPE_HTML_ON_EXPORT
IMPORT_EXPORT_ESCAPE_FORMULAE_ON_EXPORT
I have deprecated:
IMPORT_EXPORT_ESCAPE_OUTPUT_ON_EXPORT
The reason for the change is that malicious strings can be present exported to a variety of formats and still be an issue. For example, exporting bad HTML to CSV might still be an issue if the user opens the exported csv into a browser somehow.
Likewise, dodgy excel formulae could be exported to csv, tsv, ods, xls and xlsx and opened in Excel, so this need addressing for all formats.
I decided that it might be better for users to have more control over escaping, hence why two settings are used. I can envisage that if someone only ever exports to HTML, there could be cases where they don't want any leading '=' characters replaced.
Acceptance Criteria