New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic formatting and linting #1571
Add automatic formatting and linting #1571
Conversation
8b2fe71
to
8681e6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks for doing this Matthew! I think this looks solid to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am overall fine with the defaults I think, but I will say screen size has been seriously increasing and there's no real functional problem with a more modern line length. I've used 120 and it's really nice in some ways. So I'd be open to that too. If you have strong opinions though the 88 default is fine.
Hi Ryan - thanks for reviewing. I likewise don't have strong opinions on line length, however I thought it best to be as consistent as possible, so went with 88 which is the black default and used by other projects. |
@pokken-magic Hi Ryan, we are having to make some changes to the repo to support GitHub Sponsors. One change is that you will need 2FA setup on Github. Hence that is why you were removed and re-invited. If you want to contact me I can explain further. |
Problem
We have a long-standing issue in that we don't follow best practices by not having automatic linting / formatting. This PR adds rules to apply black formatting and flake8 checks.
Solution
.pre-commit-config.yaml
to include rules for formatting using black, flake8 and isort.editorconfig
I will apply global reformatting in a separate PR.
Acceptance Criteria