Include allowed formats settings #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o explain usage of the settings.
…o explain usage of the settings. add tests
matthewhegarty
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Hi @EricOuma
This is great, a really useful change. Thanks for submitting. Feel free to add your name to AUTHORS.
It will potentially improve security as well. It would be worth updating the security section in advanced_usage.rst to clarify that limiting the available imports / exports is an important security consideration.
matthewhegarty
approved these changes
Sep 7, 2023
matthewhegarty
merged commit c2b2f1e
into
django-import-export:main
8 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
XLS is becoming obsolete and is introducing problems such as #1592 and #1601
Solution
Having settings that can be used by developers to specify what formats one wants to be available to end users who know nothing about such errors.
Acceptance Criteria
Yes I have added tests and documented my changes
Settings
Import Formats Available
Export Formats Available
Export Action Formats Available
