BooleanWidget optimization

[walison17]

Small optimization on lookups using sets instead lists

[andrewgy8]

Hey! Thanks for the contrib @walison17 !

Can you explain more about why you think this optimization is necessary? Did you run into an issue with the speed of this function?

This change seems like a non-backwards compatible change, so there is a significant cost here that we must weigh.

[walison17]

hey @andrewgy8!

I wrote the FALSE_RENDER_VALUE wrong before sending this PR, was not my intention to add a breaking change on returned value, sorry about that 😅

[matthewhegarty]

Thanks for submitting the PR. I agree with @andrewgy8 that there's not enough of a benefit to merge this PR. Unless there's something else I am missing, I think the performance improvement would be negligible. If we put this change in, there is a risk that we will break existing implementations out there, i.e. if users have their own code which relies on using the 0th element of the lists.

I will close this but please note that we appreciate you creating a PR, and we encourage you to looks through existing issues and feel free to pick an issue if you want to contribute to the library. It's always worth adding comments before undertaking significant work, so that we can let you know if we think it's the right approach.