Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added testing for django5 #1634

Merged
merged 9 commits into from Dec 7, 2023

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented Sep 19, 2023

Problem

Added django5 support (marked as draft until v5 release)

Solution

Updated tox config

@coveralls
Copy link

coveralls commented Sep 19, 2023

Coverage Status

coverage: 100.0%. remained the same
when pulling 6c4c0c1 on matthewhegarty:django-5
into 42362f9 on django-import-export:main.

@matthewhegarty matthewhegarty marked this pull request as ready for review November 4, 2023 13:49
@matthewhegarty matthewhegarty marked this pull request as draft November 4, 2023 14:43
@matthewhegarty matthewhegarty marked this pull request as ready for review December 5, 2023 19:26
Copy link
Contributor

@RobTilton RobTilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need multiple lines for Django? Can we not have one that covers from 3.2 < 6.0?

@matthewhegarty
Copy link
Contributor Author

Do we need multiple lines for Django? Can we not have one that covers from 3.2 < 6.0?

Good question.

In tox.ini we need multiple lines because the tox tests run a combination of python, django etc. You can run tox at the command line and the whole suite should run (takes about 20 minutes).

In setup.py it is declared separately as metadata to other tools as to which versions of django we support.

@matthewhegarty matthewhegarty merged commit 9d7eb2a into django-import-export:main Dec 7, 2023
11 checks passed
@matthewhegarty matthewhegarty deleted the django-5 branch December 7, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants