Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation and tests for instance info after import #1643

Merged
merged 6 commits into from Sep 30, 2023
Merged

Added documentation and tests for instance info after import #1643

merged 6 commits into from Sep 30, 2023

Conversation

matthewhegarty
Copy link
Contributor

Closes #1298

What problem have you solved?

The documentation for retrieving instance information after import was not clear enough.

How did you solve the problem?

  • Added a test to prove that object information can be retrieved after import.
  • Updated documentation

pokken-magic
pokken-magic approved these changes Sep 30, 2023
View reviewed changes
Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@matthewhegarty
Copy link
Contributor Author

@pokken-magic Thanks Ryan, much appreciated.

@coveralls
Copy link

coveralls commented Sep 30, 2023 •
edited

Coverage Status

coverage: 100.0%. remained the same when pulling 2d0462a on matthewhegarty:issue-1298-read-pk-from-instance into 9c53ec3 on django-import-export:main.

@matthewhegarty matthewhegarty merged commit 77d659d into django-import-export:main Sep 30, 2023
11 checks passed
@matthewhegarty matthewhegarty deleted the issue-1298-read-pk-from-instance branch September 30, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokken-magic pokken-magic pokken-magic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instances or primary key from imported objects
3 participants
@matthewhegarty @coveralls @pokken-magic