Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor check for import_id_fields #1645

Conversation

matthewhegarty
Copy link
Contributor

Problem

Closes #1644

  • The check for invalid import_id_fields did not need to be performed for every row

Solution

  • Replaced with single check before import

Acceptance Criteria

  • Addition of tests
  • Removed unnecessary test

@matthewhegarty matthewhegarty force-pushed the issue-1644-import-id-field-check branch from 8e7835d to bb6d46d Compare October 1, 2023 11:13
Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing really blocking here, seems like an overall reasonable thing to do, but some tiny thoughts to consider.

import_export/resources.py Show resolved Hide resolved
import_export/resources.py Show resolved Hide resolved
@matthewhegarty matthewhegarty merged commit 288852c into django-import-export:release-4 Oct 1, 2023
11 checks passed
@matthewhegarty matthewhegarty deleted the issue-1644-import-id-field-check branch October 1, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants